Users/singankit/evaluation 1dp #40505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singankit
requested review from
l0lawrence,
scbedd,
weshaggard,
benbp,
luigiw,
needuv,
paulshealy1,
dargilco and
jhakulin
as code owners
There was a problem hiding this comment.
Copilot reviewed 115 out of 119 changed files in this pull request and generated no comments.
Files not reviewed (4)
- .vscode/cspell.json: Language not supported
- pylintrc: Language not supported
- sdk/ai/azure-ai-projects-onedp/MANIFEST.in: Language not supported
- sdk/ai/azure-ai-projects-onedp/apiview-properties.json: Language not supported
Comments suppressed due to low confidence (2)
sdk/ai/azure-ai-projects-onedp/azure/ai/projects/onedp/aio/_client.py:67
- The _endpoint variable is set to a literal '{endpoint}'. Confirm that the URL formatting mechanism correctly substitutes the actual endpoint value, or consider initializing it with the dynamic endpoint directly.
_endpoint = "{endpoint}"
sdk/ai/azure-ai-projects-onedp/CHANGELOG.md:15
- [nitpick] The changelog entry 'Update me' is too vague. Please provide a clear and detailed description of the changes introduced in version 1.0.0b9.
* Update me
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
dargilco
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines